RHIDP-5681: Added missing parameter in auth set up #898
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmagak
added
Peer review needed 📖
do-no-merge/review-in-progress 👀
Technical review needed 🔩
Collaborator
|
Updated preview: https://redhat-developer.github.io/red-hat-developers-documentation-rhdh/pr-898/ @ 02/28/25 10:27:08 |
JessicaJHee
suggested changes
Jan 31, 2025
Member
JessicaJHee
left a comment
JessicaJHee
left a comment
There was a problem hiding this comment.
Thank you for this! I have a few small comments.
It would also be nice to add a description here explaining this config:
Something like:
prompt: auto: To allow the identity provider to automatically determine whether to prompt for credentials or skip the login redirect if you have an active SSO session.
Some more useful information to consider including:
Without setting this value, the provider will default to prompt: none, which assumes that you are already logged on in the IDP and will reject the sign-in request without an active session.
prompt: login: will force the identity provider to always require credentials from the user.
JessicaJHee
suggested changes
Feb 4, 2025
Member
JessicaJHee
left a comment
JessicaJHee
left a comment
There was a problem hiding this comment.
I've added a few more comments, thank you!
modules/authentication/proc-enabling-authentication-with-rhbk.adoc
Outdated
Show resolved
Hide resolved
modules/authentication/proc-enabling-authentication-with-rhbk.adoc
Outdated
Show resolved
Hide resolved
modules/authentication/proc-enabling-authentication-with-rhbk.adoc
Outdated
Show resolved
Hide resolved
modules/authentication/proc-enabling-authentication-with-rhbk.adoc
Outdated
Show resolved
Hide resolved
jmagak
force-pushed
the
RHIDP-5681-Missing--parameter-configuration-in-auth-set-up
branch
from
1f43691 to
a1b8a0a
Compare
jmagak
force-pushed
the
RHIDP-5681-Missing--parameter-configuration-in-auth-set-up
branch
from
a1b8a0a to
43c5c77
Compare
jmagak
added
Technical review done ⛅
jmagak
force-pushed
the
RHIDP-5681-Missing--parameter-configuration-in-auth-set-up
branch
from
43c5c77 to
ab2b2de
Compare
jmagak
force-pushed
the
RHIDP-5681-Missing--parameter-configuration-in-auth-set-up
branch
from
ab2b2de to
d27b276
Compare
themr0c
reviewed
Feb 17, 2025
modules/authentication/proc-enabling-authentication-with-rhbk.adoc
Outdated
Show resolved
Hide resolved
themr0c
reviewed
Feb 17, 2025
modules/authentication/proc-enabling-authentication-with-rhbk.adoc
Outdated
Show resolved
Hide resolved
jmagak
force-pushed
the
RHIDP-5681-Missing--parameter-configuration-in-auth-set-up
branch
from
7e4d20a to
800a923
Compare
jmagak
added
Peer review done 📘
Ready to merge 💂
and removed
Peer review needed 📖
Ready to merge 💂
labels
jmagak
force-pushed
the
RHIDP-5681-Missing--parameter-configuration-in-auth-set-up
branch
from
242f5e9 to
cb02750
Compare
jmagak
force-pushed
the
RHIDP-5681-Missing--parameter-configuration-in-auth-set-up
branch
from
cb02750 to
1a54c57
Compare
jmagak
force-pushed
the
RHIDP-5681-Missing--parameter-configuration-in-auth-set-up
branch
from
1a54c57 to
6520bad
Compare
jmagak
force-pushed
the
RHIDP-5681-Missing--parameter-configuration-in-auth-set-up
branch
from
6520bad to
976ea42
Compare
jmagak
force-pushed
the
RHIDP-5681-Missing--parameter-configuration-in-auth-set-up
branch
from
976ea42 to
5b17678
Compare
jmagak
changed the title
jmagak
force-pushed
the
RHIDP-5681-Missing--parameter-configuration-in-auth-set-up
branch
from
5b17678 to
79cea5b
Compare
JessicaJHee
approved these changes
Feb 27, 2025
Member
JessicaJHee
left a comment
JessicaJHee
left a comment
There was a problem hiding this comment.
LGTM, thank you for these changes!
Member
|
@jmagak Please rebase the PR |
jmagak
force-pushed
the
RHIDP-5681-Missing--parameter-configuration-in-auth-set-up
branch
from
79cea5b to
e0b3d9f
Compare
jmagak
force-pushed
the
RHIDP-5681-Missing--parameter-configuration-in-auth-set-up
branch
from
e0b3d9f to
4a85786
Compare
hmanwani-rh
merged commit c1a03dd
into
redhat-developer:release-1.4
4 of 5 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the
prompt: autoconfig which is not set in the current RHDH docs for RHBK auth provider set up here.IMPORTANT: Do Not Merge - To be merged by Docs Team Only
Version(s): 1.4
Add the relevant labels to the Pull Request.
Issue: https://issues.redhat.com/browse/RHIDP-5681
Preview: https://redhat-developer.github.io/red-hat-developers-documentation-rhdh/pr-898/authentication/#enabling-authentication-with-rhbk